-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/
-----------------------------------------------------------
(Updated April 26, 2021, 4:35 p.m.)
Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and
Sarath Subramanian.
Changes
-------
Accomodated Sarath's suggestions.
Bugs: ATLAS-4195
https://issues.apache.org/jira/browse/ATLAS-4195
Repository: atlas
Description
-------
When columns for certain table are deleted or replaced, in graph we mark the
table relationship with columns(replaced or deleted) as inactive. When shuch a
table's definition is sent by Hivehook in some event(may be as refered entity),
an update audit is created for the table (irrespective of differential audit
feature being enableld or disabled).
This is because in entity comparator, where we compare relationships of stored
entity with the relationships of incoming refered table entity, we do not
ignore the inactive relationships of stored entity. This was because
mapVertexToArray method of EntityGraphRetriever did not have the capability to
ignore AtlasEdges having inactive status.
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
c13392000
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
b79002334
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/DifferentialAuditsTest.java
PRE-CREATION
repository/src/test/resources/json/entities/db01.json PRE-CREATION
repository/src/test/resources/json/entities/tbl01-2cols.json PRE-CREATION
repository/src/test/resources/json/entities/tbl01.json PRE-CREATION
Diff: https://reviews.apache.org/r/73258/diff/4/
Changes: https://reviews.apache.org/r/73258/diff/3-4/
Testing
-------
Manual testing was done.
Unit test Added.
Thanks,
Deep Singh
