----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73258/#review222857 -----------------------------------------------------------
Fix it, then Ship it! repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Lines 1188 (patched) <https://reviews.apache.org/r/73258/#comment312012> nit: remove extra indentation for if statement. if we are ignoring mapping deleted elements, rename ignoreInactive => ignoreDeleted e.g. if (ignoreDeleted && GraphHelper.getStatus((AtlasEdge) element) == AtlasEntity.Status.DELETED) { continue; } repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java Lines 1341 (patched) <https://reviews.apache.org/r/73258/#comment312013> getVertexAttributeIgnoreInactive => getVertexAttributeIgnoreDeleted - Sarath Subramanian On April 23, 2021, 6:59 a.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73258/ > ----------------------------------------------------------- > > (Updated April 23, 2021, 6:59 a.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, > and Sarath Subramanian. > > > Bugs: ATLAS-4195 > https://issues.apache.org/jira/browse/ATLAS-4195 > > > Repository: atlas > > > Description > ------- > > When columns for certain table are deleted or replaced, in graph we mark the > table relationship with columns(replaced or deleted) as inactive. When shuch > a table's definition is sent by Hivehook in some event(may be as refered > entity), an update audit is created for the table (irrespective of > differential audit feature being enableld or disabled). > > This is because in entity comparator, where we compare relationships of > stored entity with the relationships of incoming refered table entity, we do > not ignore the inactive relationships of stored entity. This was because > mapVertexToArray method of EntityGraphRetriever did not have the capability > to ignore AtlasEdges having inactive status. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > c13392000 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > b79002334 > > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/DifferentialAuditsTest.java > PRE-CREATION > repository/src/test/resources/json/entities/db01.json PRE-CREATION > repository/src/test/resources/json/entities/tbl01-2cols.json PRE-CREATION > repository/src/test/resources/json/entities/tbl01.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/73258/diff/3/ > > > Testing > ------- > > Manual testing was done. > Unit test Added. > > > Thanks, > > Deep Singh > >
