-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review222879
-----------------------------------------------------------




addons/kafka-bridge/pom.xml
Lines 143 (patched)
<https://reviews.apache.org/r/73286/#comment312051>

    Please introduce a property in the root pom and use the reference here.



addons/kafka-bridge/pom.xml
Lines 148 (patched)
<https://reviews.apache.org/r/73286/#comment312050>

    Could you please use the ${httpcomponents-httpclient.version} property here 
from the root pom? Also as I see the DefaultHttpClient has been deprecated 
since, so it might require some rework in the code too.



addons/kafka-bridge/pom.xml
Lines 153 (patched)
<https://reviews.apache.org/r/73286/#comment312052>

    Please use the ${hive.version} property here.



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
Lines 67 (patched)
<https://reviews.apache.org/r/73286/#comment312053>

    Please group public and private fields together.



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
Lines 503 (patched)
<https://reviews.apache.org/r/73286/#comment312056>

    Can we reuse this HttpClient instead of creating a new one each time?



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
Lines 38 (patched)
<https://reviews.apache.org/r/73286/#comment312059>

    What happens if there are no schema registry running? Does it throw a 
connection exception or does handle this?



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
Lines 51 (patched)
<https://reviews.apache.org/r/73286/#comment312057>

    `httpClient` is passed in via an argument which would assume that this is a 
resource handled by the caller. I think it would be nicer to close this instead 
in the caller in a `finally` block.



addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
Lines 62 (patched)
<https://reviews.apache.org/r/73286/#comment312058>

    Which methods throw IOException and UnsupportedOperationException? Do we 
have to handle them here?


- Viktor Somogyi-Vass


On April 27, 2021, 10:28 a.m., Aileen Toleikis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
> 
> (Updated April 27, 2021, 10:28 a.m.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The Kafka Community is using Schema Registry more and more heavily but as 
> Atlas is currently unaware of this, this extension helps Atlas make use of 
> the Schemas.
> 
> We have tested this extension and we have production environments where Atlas 
> will not be allowed without schema registry access. We have received feedback 
> that this extension would be sufficient to allow production use.
> 
> Changes:
> 
> initial commit
> 
> 
> added schema creation in Atlas
> 
> 
> added Schema creation, Schema linkage and started to work on versions
> 
> 
> avro_field creation is working. However, there is no connection to schemas yet
> 
> 
> smaller refactorings and improved logging
> 
> 
> added field reference in schemas
> 
> 
> deleted second README and added gitignore
> 
> 
> Smaller changes after rebasing on new version
> 
> 
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
> 
> 
> added testCreateSchema() as test case
> 
> 
> added testCreateField() and testUpdateField() as test case
> 
> 
> added testGetSchemas() and testGetSchemaVersions() as test case
> 
> 
> added testUpdateSchema() as test case
> 
> 
> removed unnecessary comments
> 
> 
> Diffs
> -----
> 
>   addons/kafka-bridge/pom.xml 7fe97eb39897e32f5e2a4104cc06948e1ec48b27 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  bf74c67454120e3bdeebab0d7cc428d6bba8c021 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
>  PRE-CREATION 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java
>  0f81b4c37a1d8f84c587a914eb460b290ae36987 
>   
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
>  f86ceb58fd250d80f3ae3c71085c8c0adbc9116b 
> 
> 
> Diff: https://reviews.apache.org/r/73286/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aileen Toleikis
> 
>

Reply via email to