> On April 27, 2021, 3:21 nachm., Viktor Somogyi-Vass wrote: > > Reviewed your code and made some smaller comments. I think overall this is > > a very useful feature to add. > > Aileen Toleikis wrote: > Hey Victor, > Thank you so much for reviewing our code! > Thanks for these valid ideas! We will fix them asap and upload a new diff!
Hi Viktor, we finally did it and added your requested changes to the code. Could you review the code again? What would be the next step? Kind regards, Aileen - Aileen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73286/#review222880 ----------------------------------------------------------- On Sept. 3, 2021, 7:42 vorm., Aileen Toleikis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73286/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2021, 7:42 vorm.) > > > Review request for atlas. > > > Repository: atlas > > > Description > ------- > > The Kafka Community is using Schema Registry more and more heavily but as > Atlas is currently unaware of this, this extension helps Atlas make use of > the Schemas. > > We have tested this extension and we have production environments where Atlas > will not be allowed without schema registry access. We have received feedback > that this extension would be sufficient to allow production use. > > Changes: > > initial commit > > > added schema creation in Atlas > > > added Schema creation, Schema linkage and started to work on versions > > > avro_field creation is working. However, there is no connection to schemas yet > > > smaller refactorings and improved logging > > > added field reference in schemas > > > deleted second README and added gitignore > > > Smaller changes after rebasing on new version > > > moved HTTP REST calls to a separate class (SchemaRegistryConnector.java) > > > added testCreateSchema() as test case > > > added testCreateField() and testUpdateField() as test case > > > added testGetSchemas() and testGetSchemaVersions() as test case > > > added testUpdateSchema() as test case > > > removed unnecessary comments > > > Diffs > ----- > > addons/kafka-bridge/pom.xml 7fe97eb39897e32f5e2a4104cc06948e1ec48b27 > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > bf74c67454120e3bdeebab0d7cc428d6bba8c021 > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java > PRE-CREATION > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java > 0f81b4c37a1d8f84c587a914eb460b290ae36987 > > addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java > f86ceb58fd250d80f3ae3c71085c8c0adbc9116b > pom.xml 092ba09cee93ca703e29d8ae1afaa20559a06227 > > > Diff: https://reviews.apache.org/r/73286/diff/2/ > > > Testing > ------- > > > Thanks, > > Aileen Toleikis > >
