> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/pom.xml
> > Lines 143 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248948#file2248948line143>
> >
> >     Please introduce a property in the root pom and use the reference here.

Handled in diff2: introduced the property in the root pom


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/pom.xml
> > Lines 148 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248948#file2248948line148>
> >
> >     Could you please use the ${httpcomponents-httpclient.version} property 
> > here from the root pom? Also as I see the DefaultHttpClient has been 
> > deprecated since, so it might require some rework in the code too.

Handled in diff2: modified to http version parameter, replaced deprecated 
DefaultHttpClient with ClosableHttpClient


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/pom.xml
> > Lines 153 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248948#file2248948line153>
> >
> >     Please use the ${hive.version} property here.

Handled in diff2: modified to hive version parameter


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
> > Lines 67 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248949#file2248949line67>
> >
> >     Please group public and private fields together.

Handled in diff2: regrouped the fields


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
> > Lines 503 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248949#file2248949line504>
> >
> >     Can we reuse this HttpClient instead of creating a new one each time?

Handled in diff2: we are reusing the httpclient now


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
> > Lines 38 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248950#file2248950line38>
> >
> >     What happens if there are no schema registry running? Does it throw a 
> > connection exception or does handle this?

Handled in diff2: added another else for the case of no schema registry found, 
evth else continues because schema registry is not an requirement


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
> > Lines 51 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248950#file2248950line51>
> >
> >     `httpClient` is passed in via an argument which would assume that this 
> > is a resource handled by the caller. I think it would be nicer to close 
> > this instead in the caller in a `finally` block.

Handled in diff2: closed in finally block


> On April 27, 2021, 3:19 nachm., Viktor Somogyi-Vass wrote:
> > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
> > Lines 62 (patched)
> > <https://reviews.apache.org/r/73286/diff/1/?file=2248950#file2248950line62>
> >
> >     Which methods throw IOException and UnsupportedOperationException? Do 
> > we have to handle them here?

Handled in diff2: added log-information for the response exception


- Aileen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review222879
-----------------------------------------------------------


On Sept. 3, 2021, 7:42 vorm., Aileen Toleikis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2021, 7:42 vorm.)
> 
> 
> Review request for atlas.
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> The Kafka Community is using Schema Registry more and more heavily but as 
> Atlas is currently unaware of this, this extension helps Atlas make use of 
> the Schemas.
> 
> We have tested this extension and we have production environments where Atlas 
> will not be allowed without schema registry access. We have received feedback 
> that this extension would be sufficient to allow production use.
> 
> Changes:
> 
> initial commit
> 
> 
> added schema creation in Atlas
> 
> 
> added Schema creation, Schema linkage and started to work on versions
> 
> 
> avro_field creation is working. However, there is no connection to schemas yet
> 
> 
> smaller refactorings and improved logging
> 
> 
> added field reference in schemas
> 
> 
> deleted second README and added gitignore
> 
> 
> Smaller changes after rebasing on new version
> 
> 
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
> 
> 
> added testCreateSchema() as test case
> 
> 
> added testCreateField() and testUpdateField() as test case
> 
> 
> added testGetSchemas() and testGetSchemaVersions() as test case
> 
> 
> added testUpdateSchema() as test case
> 
> 
> removed unnecessary comments
> 
> 
> Diffs
> -----
> 
>   addons/kafka-bridge/pom.xml 7fe97eb39897e32f5e2a4104cc06948e1ec48b27 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
>  bf74c67454120e3bdeebab0d7cc428d6bba8c021 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java
>  PRE-CREATION 
>   
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java
>  0f81b4c37a1d8f84c587a914eb460b290ae36987 
>   
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
>  f86ceb58fd250d80f3ae3c71085c8c0adbc9116b 
>   pom.xml 092ba09cee93ca703e29d8ae1afaa20559a06227 
> 
> 
> Diff: https://reviews.apache.org/r/73286/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aileen Toleikis
> 
>

Reply via email to