> On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java > > Line 423 (original), 423 (patched) > > <https://reviews.apache.org/r/75150/diff/4/?file=2292826#file2292826line423> > > > > else block at #427 also needs to be updated to handle shell entity, > > right? Please review. > > > > I suggest the following: > > > > #416: if (value != null) { > > # ... > > #418: } else if (!attributeDef.getIsOptional()) { > > if (entityObj.isIncomplete()) { > > continue; > > }
Shell Entity will be instance of AtlasEntity, hence this condition will not come for else block > On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > > Lines 1254 (patched) > > <https://reviews.apache.org/r/75150/diff/4/?file=2292828#file2292828line1254> > > > > Looking at #1252, this block should be executed only for full-updates > > i.e. not partial update. In such case, shouldn't the vertex be updated to > > clear is-incomplete flag? > > > > Perhaps #1252 should be replaced with: > > if (!isPartialUpdate && (entity.getIsIncomplete() == null || > > !entity.getIsIncomplete())) { For export/import scenario, Consider target cluster has "A" shell entity, export file has again same "A" shell entity, in this case we need not to convert it to actual entity, since export file has shell entity Also for imports, isPartialUpdate is explicilty set to false. - Priyanshi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75150/#review226865 ----------------------------------------------------------- On Aug. 16, 2024, 11:36 a.m., Priyanshi Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75150/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2024, 11:36 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4892 > https://issues.apache.org/jira/browse/ATLAS-4892 > > > Repository: atlas > > > Description > ------- > > Problem: > > During import, if shell entity is present in the importing file, import is > getting failed. > > Solution: > > There is mandatory attribute check present which was not allowing to create > shell entity and the import was getting failed due to this implementation. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > b51951fe2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 656c9d14b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 77ab99a96 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java > 2f37eac6b > > > Diff: https://reviews.apache.org/r/75150/diff/4/ > > > Testing > ------- > > > Thanks, > > Priyanshi Shah > >
