> On Aug. 19, 2024, 9:25 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > > Line 1272 (original), 1271 (patched) > > <https://reviews.apache.org/r/75150/diff/4/?file=2292828#file2292828line1273> > > > > Why is it necessary to skip adding incomplete entities to > > context.addUpdated() and context.addCreated() - #1272 and #1294 below?
It is skipped to avoid adding first class/default attributes in the shell entity. Eg: shell entity of hive_table will add default attributes like rentention,temporary etc. if these methods are not skipped. Adding those would differ the entity attributes with target cluster - Priyanshi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75150/#review226865 ----------------------------------------------------------- On Aug. 23, 2024, 10:46 a.m., Priyanshi Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75150/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2024, 10:46 a.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4892 > https://issues.apache.org/jira/browse/ATLAS-4892 > > > Repository: atlas > > > Description > ------- > > Problem: > > During import, if shell entity is present in the importing file, import is > getting failed. > > Solution: > > There is mandatory attribute check present which was not allowing to create > shell entity and the import was getting failed due to this implementation. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > b51951fe2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 656c9d14b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 77ab99a96 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java > 2f37eac6b > > > Diff: https://reviews.apache.org/r/75150/diff/5/ > > > Testing > ------- > > > Thanks, > > Priyanshi Shah > >
