----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75150/#review226887 -----------------------------------------------------------
Ship it! Ship It! - Pinal Shah On Aug. 23, 2024, 1:47 p.m., Priyanshi Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75150/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2024, 1:47 p.m.) > > > Review request for atlas, Jayendra Parab, Mandar Ambawane, Pinal Shah, and > Sheetal Shah. > > > Bugs: ATLAS-4892 > https://issues.apache.org/jira/browse/ATLAS-4892 > > > Repository: atlas > > > Description > ------- > > Problem: > > During import, if shell entity is present in the importing file, import is > getting failed. > > Solution: > > There is mandatory attribute check present which was not allowing to create > shell entity and the import was getting failed due to this implementation. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 60e57a379 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java ffbe9e7d8 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityGraphDiscoveryV2.java > b51951fe2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java > 656c9d14b > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > 77ab99a96 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IDBasedEntityResolver.java > 2f37eac6b > > > Diff: https://reviews.apache.org/r/75150/diff/6/ > > > Testing > ------- > > Tested below scenarios : > > 1. Created shell entity through beeline it is working fine. > 2. Tried with export file which has hive_column as shell entity it is also > working fine. > 3. Had one export file which has shell entity for spark_column_lineage and it > worked fine. > 4. Tried running same exported file which has same shell entity again . > 5. Incremental export file should have entity (shell entity in the earlier > export) which is now resolved to actual entity. > 6. Ran export file without having shell entity. > 7. Created entity through API. > > > Thanks, > > Priyanshi Shah > >
