pawarprasad123 commented on code in PR #703:
URL: https://github.com/apache/atlas/pull/703#discussion_r3819564520
##########
dashboard/package.json:
##########
Review Comment:
PR description is partially outdated
The description mentions bumping axios to 1.15.2 and vite to 6.4.2, but vs
current master the only package.json diff is the overrides block. Direct deps
like axios (1.18.1) and vite (6.4.3) are already on master. The real value is
the lockfile transitive bumps.
##########
dashboard/package.json:
##########
@@ -113,11 +113,12 @@
},
"overrides": {
"semver": "7.5.4",
- "minimatch": "9.0.7",
- "brace-expansion": "5.0.6",
"d3-color": "3.1.0",
"lodash": "4.18.1",
"lodash-es": "4.18.1",
- "js-yaml": "4.3.0"
+ "brace-expansion": "5.0.9",
+ "js-yaml": "5.3.0",
+ "minimatch": "9.0.7",
+ "postcss": "8.5.25"
Review Comment:
postcss: "8.5.25" override — good. Confirm this applies globally and doesn't
conflict with Vite's expected postcss range (build passed, so likely fine).
##########
dashboard/package.json:
##########
@@ -51,11 +51,11 @@
"react-hook-form": "7.53.0",
"react-idle-timer": "5.7.2",
"react-querybuilder": "8.0.0",
- "react-quill-new": "3.4.1",
+ "react-quill-new": "3.8.3",
"react-redux": "9.1.0",
"react-router-dom": "6.30.4",
"react-toastify": "10.0.5",
- "recharts": "2.15.1",
+ "recharts": "3.10.1",
Review Comment:
Typecheck (npm run typecheck)
9 TypeScript errors from Recharts v3 API changes
Build:check (npm run build:check)
Fails on same TS errors
Full test suite
4849 passed; 6 failed in local BMAttributes.test.tsx (local unstaged work,
not from this PR)
[email protected] introduces breaking TypeScript API changes. The PR upgrades the
package but includes zero source updates. These files fail npm run typecheck:
<div class="ui-scroll-area" data-scroll-padding="4" data-visibility="hover"
data-direction="horizontal" style="--tw-space-y-reverse: 0; margin-block: 0px
16px; --scrollbar-size: 6px; --scrollbar-inset: 0px;
--scrollbar-thumb-top-offset: 6px; --scroll-area-scroll-padding: 4px; position:
relative; overflow: hidden; display: grid; grid-template: 1fr / 1fr; margin:
1em 0px; border-color: color(srgb 0.894118 0.894118 0.894118 / 0.0737255);
border-style: solid; border-width: 1px; border-image: none 100% / 1 / 0
stretch; border-radius: 6px; color: rgba(228, 228, 228, 0.92); font-family:
-apple-system, "system-ui", sans-serif; font-size: 13px; font-style:
normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight:
400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px;
text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; white-space: normal; background-color: rgb(24, 24, 24);
text-decoration-thickness: init
ial; text-decoration-style: initial; text-decoration-color: initial;"><div
class="ui-scroll-area__viewport" style="grid-area: 1 / 1; min-height: 0px;
max-height: 100%; border-radius: inherit; overflow: auto hidden;
scroll-padding: 0px 4px; overscroll-behavior: contain auto; scrollbar-width:
none !important;"><div class="ui-scroll-area__content" style="box-sizing:
border-box; width: auto; min-width: 100%; max-width: 100%; min-height: 100%;
display: flex; flex-direction: row; height: fit-content;">
File | Line(s) | Issue
-- | -- | --
EntityStatusDonut.tsx | 150 | activeIndex prop removed/changed on <Pie>
EntityStatusDonut.tsx | 161 | Tooltip formatter signature changed (ValueType
\| undefined vs number)
EntityTypeBarChart.tsx | 308 | LabelList formatter expects RenderableText,
not (v: number) => string
MessageConsumptionChart.tsx | 237 | Same LabelList formatter issue
ClassificationDistributionCard.tsx | 206 | Bar onClick —
BarRectangleItem.name is string \| undefined
ClassificationDistributionCard.tsx | 213 | Same LabelList formatter issue
EntityStatsChart.tsx | 91–95 | Legend API changed — id missing on
LegendPayload, payload prop removed
</div></div></div><br class="Apple-interchange-newline">
##########
dashboard/package.json:
##########
@@ -113,11 +113,12 @@
},
"overrides": {
"semver": "7.5.4",
Review Comment:
Consider sorting overrides alphabetically for maintainability (optional).
##########
dashboard/package.json:
##########
@@ -113,11 +113,12 @@
},
"overrides": {
"semver": "7.5.4",
- "minimatch": "9.0.7",
- "brace-expansion": "5.0.6",
"d3-color": "3.1.0",
"lodash": "4.18.1",
"lodash-es": "4.18.1",
- "js-yaml": "4.3.0"
+ "brace-expansion": "5.0.9",
+ "js-yaml": "5.3.0",
Review Comment:
js-yaml: "5.3.0" is a major bump via override. Please confirm all consumers
were validated (Jest/istanbul tooling uses js-yaml transitively). Tests pass
locally — consider adding a one-line note in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
