pawarprasad123 commented on code in PR #703:
URL: https://github.com/apache/atlas/pull/703#discussion_r3843452925
##########
dashboard/src/views/DashboardOverview/ClassificationDistributionCard.tsx:
##########
@@ -44,6 +44,9 @@ import {
} from "./dashboardChartPalette";
Review Comment:
dashboard/src/views/DashboardOverview/ClassificationDistributionCard.tsx
line - 209
Bar onClick should extract name from payload (like
EntityTypeBarChart.payloadFromBarEvent) instead of casting to Record<string,
string>. Guard against empty name before navigation.
dashboard/src/views/DashboardOverview/EntityStatusDonut.tsx
line 151–152
Please add unit tests for pie click navigation and tooltip formatter. This
component has no dedicated test file despite significant Recharts v3 changes.
dashboard/src/views/Statistics/EntityStatsChart.tsx
line 104–111
Legend items need keyboard accessibility: role="button", tabIndex={0},
aria-label, and onKeyDown for Enter/Space — consistent with Y-axis tick buttons
in other chart components.
dashboard/src/views/DashboardOverview/ClassificationDistributionCard.tsx
line 47–49
NSIVE_CONTAINER_STYLE, LABEL_LIST_STYLE, and getTickGStyle to
dashboardChartPalette.ts — duplicated in EntityTypeBarChart.
dashboard/src/views/Statistics/__tests__/EntityStats.test.tsx
line 506–534
Tests for "null event" / "no id" are obsolete with the custom legend.
Replace with direct clicks on legend-Deleted/legend-Shell asserting area
visibility toggles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
