Brijesh619 commented on code in PR #703:
URL: https://github.com/apache/atlas/pull/703#discussion_r3841128716
##########
dashboard/package.json:
##########
@@ -113,11 +113,12 @@
},
"overrides": {
"semver": "7.5.4",
Review Comment:
I actually ended up removing almost all of the overrides entirely in my
latest commit (leaving only d3-color), as bumping the direct dependencies fixed
the issues directly. So sorting is no longer needed here!
##########
dashboard/package.json:
##########
@@ -51,11 +51,11 @@
"react-hook-form": "7.53.0",
"react-idle-timer": "5.7.2",
"react-querybuilder": "8.0.0",
- "react-quill-new": "3.4.1",
+ "react-quill-new": "3.8.3",
"react-redux": "9.1.0",
"react-router-dom": "6.30.4",
"react-toastify": "10.0.5",
- "recharts": "2.15.1",
+ "recharts": "3.10.1",
Review Comment:
I've updated the components to align with Recharts v3's API changes:
<Pie> no longer requires manual activeIndex state for hover effects, so I
removed it.
Handled stricter formatter signatures across <Tooltip> and <LabelList>.
Fixed <Bar onClick> strictly expecting a non-undefined string.
Adjusted <Legend> payload to accommodate the removal of the id property from
LegendPayload and its prop constraints.
npm run typecheck now passes completely locally with 0 errors!"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
