> On Sept. 26, 2016, 10:29 a.m., Shwetha GS wrote: > > 1. Can you add a test with lineage query on column? > > 2. ReservedTypesRegistrar should change to updateTypes, so that upgrades > > work > > 3. Once you make sure the tests work, disable the tests so that tests don't > > break with apache hive 1.2
Added test with lineage API query ReservedTypesRegistrar changes will be addressed in ATLAS-1184. I will be uploading patch for ATLAS-1184 shortly Disabled the test after verifying its working - Vimal ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52077/#review150383 ----------------------------------------------------------- On Sept. 26, 2016, 1:06 p.m., Vimal Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52077/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 1:06 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1184 and ATLAS-247 > https://issues.apache.org/jira/browse/ATLAS-1184 > https://issues.apache.org/jira/browse/ATLAS-247 > > > Repository: atlas > > > Description > ------- > > After a CTAS query, lineage relationship between source columns and > destination column can be captured. This information can be used to create a > column lineage process. > > > Diffs > ----- > > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java > PRE-CREATION > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java > a3464a0 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataModelGenerator.java > 45f0bc9 > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/model/HiveDataTypes.java > e094cb6 > addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java > a5838b4 > > Diff: https://reviews.apache.org/r/52077/diff/ > > > Testing > ------- > > > Thanks, > > Vimal Sharma > >
