-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56260/#review164318
-----------------------------------------------------------



the patch doesn't apply. can you please rebase with the latest master?


addons/models/0030-hive_model.json (line 216)
<https://reviews.apache.org/r/56260/#comment236011>

    "typeName": "hive_storagedesc" ==> "typeName": "."
     - this doesn't look right. please review.


- Madhan Neethiraj


On Feb. 6, 2017, 7:15 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56260/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 7:15 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, 
> and Vimal Sharma.
> 
> 
> Bugs: ATLAS-1523
>     https://issues.apache.org/jira/browse/ATLAS-1523
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Current implementation of GET API for entity v2 still routes to V1 entity 
> APIs and does a V1toV2 conversion. We need to directly query the v2 
> entitiesStore to get the required entity.
> 
> 
> Diffs
> -----
> 
>   addons/models/0030-hive_model.json 561cf5b 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 0fb16c6 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 9494fe4 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> ce8d4c7 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  c42f95f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  4c79cef 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java
>  546cd0c 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java aa209f9 
> 
> Diff: https://reviews.apache.org/r/56260/diff/
> 
> 
> Testing
> -------
> 
> Tested using POSTMAN
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Reply via email to