----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56260/#review164373 -----------------------------------------------------------
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java (line 196) <https://reviews.apache.org/r/56260/#comment236069> Put and then assign. If somehow other thread manages to clear up the map then a put after assign might not work. repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java (line 660) <https://reviews.apache.org/r/56260/#comment236070> Extra braces not needed. repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java (line 67) <https://reviews.apache.org/r/56260/#comment236071> Might be a good idea to rename these two classes, the names are somewhat similar and confusing. server-api/src/main/java/org/apache/atlas/services/MetadataService.java (line 51) <https://reviews.apache.org/r/56260/#comment236072> Revert this webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java (line 414) <https://reviews.apache.org/r/56260/#comment236074> It looks like parsing logic for the query parameters of the form attr:key=value. Since it's being used in the context of get by unique attribute REST call, why not just use the key=value as the parameters for the call directly rather than prefixing them with the attr: Also I don't see a corresponding change in the AtlasClient code to ensure that the call gets translated correctly, each parameter key in the client should be prefixed with "attr:" in this case. If this prefix is dropped then the client code should be ok. - Apoorv Naik On Feb. 6, 2017, 9:55 a.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56260/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 9:55 a.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, > and Vimal Sharma. > > > Bugs: ATLAS-1523 > https://issues.apache.org/jira/browse/ATLAS-1523 > > > Repository: atlas > > > Description > ------- > > Current implementation of GET API for entity v2 still routes to V1 entity > APIs and does a V1toV2 conversion. We need to directly query the v2 > entitiesStore to get the required entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 89e978d > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > ed0fabb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 9e08282 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 6cbb602 > server-api/src/main/java/org/apache/atlas/services/MetadataService.java > d5d8d9b > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6 > webapp/src/test/java/org/apache/atlas/web/adapters/TestEntityREST.java > 2d49c47 > > Diff: https://reviews.apache.org/r/56260/diff/ > > > Testing > ------- > > Tested using POSTMAN > > > Thanks, > > Sarath Subramanian > >
