> On Feb. 5, 2017, 11:24 p.m., Madhan Neethiraj wrote: > > addons/models/0030-hive_model.json, line 216 > > <https://reviews.apache.org/r/56260/diff/4/?file=1624614#file1624614line216> > > > > "typeName": "hive_storagedesc" ==> "typeName": "." > > - this doesn't look right. please review.
went with the commit, reverted in updated patch - Sarath ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56260/#review164318 ----------------------------------------------------------- On Feb. 5, 2017, 11:55 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56260/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2017, 11:55 p.m.) > > > Review request for atlas, Apoorv Naik, Madhan Neethiraj, Suma Shivaprasad, > and Vimal Sharma. > > > Bugs: ATLAS-1523 > https://issues.apache.org/jira/browse/ATLAS-1523 > > > Repository: atlas > > > Description > ------- > > Current implementation of GET API for entity v2 still routes to V1 entity > APIs and does a V1toV2 conversion. We need to directly query the v2 > entitiesStore to get the required entity. > > > Diffs > ----- > > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49289d8 > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java de57145 > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 89e978d > > repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java > ed0fabb > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java > 9e08282 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/GraphEntityMapper.java > PRE-CREATION > > repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java > 6cbb602 > webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 9c0ccf6 > > Diff: https://reviews.apache.org/r/56260/diff/ > > > Testing > ------- > > Tested using POSTMAN > > > Thanks, > > Sarath Subramanian > >
