----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/#review173110 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java Line 153 (original), 138 (patched) <https://reviews.apache.org/r/58746/#comment246182> Please review exising use of getPropertyKey() API, to ensure that encodePropertyKey() is not called multiple times. For example, GraphBackedTypeStore.getEnumType(): for (String value : values) { String valueProperty = getPropertyKey(typeName, value); enumValues.add(new EnumValue(value, GraphHelper.getSingleValuedProperty(vertex, valueProperty, Integer.class))); GraphHelper.getSingleValuedProperty() calls encodePropertyKey(valueProperty). - Madhan Neethiraj On April 26, 2017, 7:09 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58746/ > ----------------------------------------------------------- > > (Updated April 26, 2017, 7:09 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1736 > https://issues.apache.org/jira/browse/ATLAS-1736 > > > Repository: atlas > > > Description > ------- > > Added empty attribute(s) check and dealing with special characters like > $,%,{,} (reserved for special titan) > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > f154555b > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7037d1eb > > > Diff: https://reviews.apache.org/r/58746/diff/1/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
