----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/#review173595 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java Line 323 (original), 308 (patched) <https://reviews.apache.org/r/58746/#comment246581> It seems that type names do not support these strange characters. What are the allowed characters for attribute names? I suspect we may need to back tick these strange names in search strings as we are doing for types - if we allow them. - David Radley On May 2, 2017, midnight, Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58746/ > ----------------------------------------------------------- > > (Updated May 2, 2017, midnight) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath > Subramanian, and Suma Shivaprasad. > > > Bugs: ATLAS-1730, ATLAS-1736 and ATLAS-1747 > https://issues.apache.org/jira/browse/ATLAS-1730 > https://issues.apache.org/jira/browse/ATLAS-1736 > https://issues.apache.org/jira/browse/ATLAS-1747 > > > Repository: atlas > > > Description > ------- > > 1. Added empty attribute(s) check > 2. Dealing with special characters like $,%,{,} (titan treats these specially) > 3. Update of attribute type is not allowed anymore > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > 6f1b80c8 > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7037d1eb > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > c08bb881 > > > Diff: https://reviews.apache.org/r/58746/diff/5/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
