----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58746/#review173463 -----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java Lines 437 (patched) <https://reviews.apache.org/r/58746/#comment246451> if attributeDef is a new attribute, currentStructDef.getAttribute(attributeDef.getName()) will return null and .getTypeName() on the return value will be NPE. Can you please review? - Madhan Neethiraj On April 28, 2017, 4:25 p.m., Apoorv Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58746/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 4:25 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1730 and ATLAS-1736 > https://issues.apache.org/jira/browse/ATLAS-1730 > https://issues.apache.org/jira/browse/ATLAS-1736 > > > Repository: atlas > > > Description > ------- > > Added empty attribute(s) check and dealing with special characters like > $,%,{,} (reserved for special titan) > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java > f154555b > > repository/src/main/java/org/apache/atlas/repository/typestore/GraphBackedTypeStore.java > 7037d1eb > > repository/src/test/java/org/apache/atlas/repository/typestore/GraphBackedTypeStoreTest.java > c08bb881 > > > Diff: https://reviews.apache.org/r/58746/diff/2/ > > > Testing > ------- > > mvn clean package executes successfully > > > Thanks, > > Apoorv Naik > >
