Niclas Hedhman wrote: > I had a quick look, and have some comments (hope you won't be > discouraged); > > 1. The code I looked at had, IMO, far too large method bodies (see 2)
can you be more specific? besides com.twcfinancial.validator.schematron.DOMSchemaValidator which has a big method that should be broken down for clarity, I don't see other candidate classes. > 2. No tests exists. that's true. > How do you they work? well, for that you have to look at the code. if you mean, how they should be used, then yes, there should be some code and configuration examples. > And you will need smaller methods for reasonable tests. what is a reasonable test?.... especially for components that live in a container.... > 3. Docs? What do these thing do? if you didn't get that from the API then I failed, because I believe the code is the documentation. I guess I can have some javadocs for better defining the context in which these API-s can be used. > Don't need to very elaborate, but a > component that I don't know what it does, I won't use. Sorry don't > have time to look at source to figure out if it does what I need. Here is a small description for every component: http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/webtop/webtop/components/marshaller/ - API for marshalling JavaBeans to XML and back (unmarshalling). Castor is used for the implementation. the API merely provides service interfaces. http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/webtop/webtop/components/steppingstone/ - workflow API. the implementation provides a configurable finite state machine with pluggable components. the components are actors that you can find in a UML state diagram: Actions, and Guards.... transitions and events are used for wiring these components into a state machine. http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/webtop/webtop/components/validator/ - SAX based validator for XML documents. the implementation uses Schematron as schema definition. Schematron was chosen as the default implementation for its ability to specify schema violation messages. this API was created to separate the concern of validation from the one of parsing a XML document. Mircea --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
