Mircea Toma said: > Niclas Hedhman wrote: > >> I had a quick look, and have some comments (hope you won't be >> discouraged); >> >> 1. The code I looked at had, IMO, far too large method bodies >> (see 2) > > can you be more specific? besides > com.twcfinancial.validator.schematron.DOMSchemaValidator which has > a big method that should be broken down for clarity, I don't see > other candidate classes.
I took a look at http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/webtop/webtop/components/steppingstone/src/java/com/twcfinancial/steppingstone/component/DefaultWorkflow.java?rev=1.1&content-type=text/vnd.viewcvs-markup with a massive trigger() method. >> 2. No tests exists. > > that's true. > >> How do you they work? > > well, for that you have to look at the code. if you mean, how they > should be used, then yes, there should be some code and > configuration examples. Sorry, a "know" is missing; "How do you know they work?" >> And you will need smaller methods for reasonable tests. > > what is a reasonable test?.... especially for components that live > in a container.... Well, anything beyond member = methodParameter; is potentially not working. Once you get Test-infected there is hardly any "too small tests", since once the test infrastructure is in place, it is very quick to add small tests. >> 3. Docs? What do these thing do? > > if you didn't get that from the API then I failed, because I > believe the code is the documentation. I guess I can have some > javadocs for better defining the context in which these API-s > can be used. When I said "not elaborate" a potential Component User want a short description in an overview page of what the component provides. Think of freashmeat.net. If you could get a quick "blurb" on each program, you would drown when trying to find what you really need. It is perhaps not apparent, when "I have these components, use it if you like", but hopefully such announcements will be so frequent that I can't track them, and want some easy to understand description decoupled from the code. Niclas --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
