[ 
https://issues.apache.org/jira/browse/AVRO-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097789#comment-14097789
 ] 

Sachin Goyal commented on AVRO-680:
-----------------------------------


Please see my comment on 06/Aug/14 11:49

It doesn't appear that one can find out the non-string (and hence the array) 
nature of datum without
its corresponding java.lang.reflect.Field or Schema object.

On seeing the call hierarchy for isMap/isArray, it seems that they do not have 
too many callers and
the callers would need to add a case for non-string map-keys if they really 
need it.
!isMap_Call_Hierarchy.png!
That's why the patch is adding a special case for it in one of the callers 
#resolveUnion

If there is another way, please suggest.

> Allow for non-string keys
> -------------------------
>
>                 Key: AVRO-680
>                 URL: https://issues.apache.org/jira/browse/AVRO-680
>             Project: Avro
>          Issue Type: Improvement
>    Affects Versions: 1.7.6, 1.7.7
>            Reporter: Jeremy Hanna
>         Attachments: AVRO-680.patch, isMap_Call_Hierarchy.png, 
> non_string_map_keys.zip, non_string_map_keys2.zip, non_string_map_keys3.zip, 
> non_string_map_keys4.patch, non_string_map_keys5.patch, 
> non_string_map_keys6.patch
>
>
> Based on an email thread back in April, Doug Cutting proposed a possible 
> solution for having non-string keys:
> Stu Hood wrote:
> > I can understand the reasoning behind AVRO-9, but now I need to look for an 
> > alternative to a 'map' that will allow me to store an association of bytes 
> > keys to values.
> A map of Foo has the same binary format as an array of records, each
> with a string field and a Foo field.  So an application can use an array
> schema similar to this to represent map-like structures with, e.g.,
> non-string keys.
> Perhaps we could establish standard properties that indicate that a
> given array of records should be represented in a map-like way if
> possible?  E.g.,:
> {"type": "array", "isMap": true, "items": {"type":"record", ...}}
> Doug



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to