[
https://issues.apache.org/jira/browse/AVRO-1658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954514#comment-15954514
]
Suraj Acharya commented on AVRO-1658:
-------------------------------------
Tests on merging with master are failing.
{code}
Tests run: 4, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 0.993 sec <<<
FAILURE! - in org.apache.avro.tool.TestSpecificCompilerTool
testCompileSchemaTwoFiles(org.apache.avro.tool.TestSpecificCompilerTool) Time
elapsed: 0.706 sec <<< FAILURE!
org.junit.ComparisonFailure: Found file:
target/compiler/output/avro/examples/baseball/Player.java does not match
expected file: src/test/compiler/output/Player.java expected:<...Builder other)
{ [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
at
org.apache.avro.tool.TestSpecificCompilerTool.assertFileMatch(TestSpecificCompilerTool.java:140)
at
org.apache.avro.tool.TestSpecificCompilerTool.testCompileSchemaTwoFiles(TestSpecificCompilerTool.java:98)
testCompileSchemasUsingString(org.apache.avro.tool.TestSpecificCompilerTool)
Time elapsed: 0.11 sec <<< FAILURE!
org.junit.ComparisonFailure: Found file:
target/compiler/output-string/avro/examples/baseball/Player.java does not match
expected file:
src/test/compiler/output-string/avro/examples/baseball/Player.java
expected:<...Builder other) { [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.String first_name; private
java.lang.String last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.String first_name; private
java.lang.String last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
at
org.apache.avro.tool.TestSpecificCompilerTool.assertFileMatch(TestSpecificCompilerTool.java:140)
at
org.apache.avro.tool.TestSpecificCompilerTool.testCompileSchemasUsingString(TestSpecificCompilerTool.java:121)
testCompileSchemaFileAndDirectory(org.apache.avro.tool.TestSpecificCompilerTool)
Time elapsed: 0.064 sec <<< FAILURE!
org.junit.ComparisonFailure: Found file:
target/compiler/output/avro/examples/baseball/Player.java does not match
expected file: src/test/compiler/output/Player.java expected:<...Builder other)
{ [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
at
org.apache.avro.tool.TestSpecificCompilerTool.assertFileMatch(TestSpecificCompilerTool.java:140)
at
org.apache.avro.tool.TestSpecificCompilerTool.testCompileSchemaFileAndDirectory(TestSpecificCompilerTool.java:109)
Running org.apache.avro.tool.TestToTrevniTool
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.414 sec - in
org.apache.avro.tool.TestToTrevniTool
Running org.apache.avro.tool.TestCatTool
Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.313 sec - in
org.apache.avro.tool.TestCatTool
Running org.apache.avro.tool.TestDataFileTools
Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.473 sec - in
org.apache.avro.tool.TestDataFileTools
Results :
Failed tests:
TestSpecificCompilerTool.testCompileSchemaFileAndDirectory:109->assertFileMatch:140
Found file: target/compiler/output/avro/examples/baseball/Player.java does not
match expected file: src/test/compiler/output/Player.java expected:<...Builder
other) { [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
TestSpecificCompilerTool.testCompileSchemaTwoFiles:98->assertFileMatch:140
Found file: target/compiler/output/avro/examples/baseball/Player.java does not
match expected file: src/test/compiler/output/Player.java expected:<...Builder
other) { [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.CharSequence first_name; private
java.lang.CharSequence last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
TestSpecificCompilerTool.testCompileSchemasUsingString:121->assertFileMatch:140
Found file: target/compiler/output-string/avro/examples/baseball/Player.java
does not match expected file:
src/test/compiler/output-string/avro/examples/baseball/Player.java
expected:<...Builder other) { [if (other == null) { return new
avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * Creates a new
Player RecordBuilder by copying an existing Player instance. * @param other
The existing instance to copy. * @return A new Player RecordBuilder */
public static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { if (other == null) {
return new avro.examples.baseball.Player.Builder(); } else { return new
avro.examples.baseball.Player.Builder(other); } } /** * RecordBuilder
for Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.String first_name; private
java.lang.String last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= other.fieldSetFlags()[0]; } if (isValidValue(fields()[1],
other.first_name)) { this.first_name =
data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = other.fieldSetFlags()[1]; } if
(isValidValue(fields()[2], other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = other.fieldSetFlags()[2]; } if
(isValidValue(fields()[3], other.position)) { this.position =
data().deepCopy(fields()[3].schema(), other.position);
fieldSetFlags()[3] = other.fieldSetFlags()[3]; } } /** * Creates
a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) {] super(SCHEMA$)...> but
was:<...Builder other) { [return new
avro.examples.baseball.Player.Builder(other); } /** * Creates a new Player
RecordBuilder by copying an existing Player instance. * @param other The
existing instance to copy. * @return A new Player RecordBuilder */ public
static avro.examples.baseball.Player.Builder
newBuilder(avro.examples.baseball.Player other) { return new
avro.examples.baseball.Player.Builder(other); } /** * RecordBuilder for
Player instances. */ public static class Builder extends
org.apache.avro.specific.SpecificRecordBuilderBase<Player> implements
org.apache.avro.data.RecordBuilder<Player> { /** The number of the player */
private int number; private java.lang.String first_name; private
java.lang.String last_name; private
java.util.List<avro.examples.baseball.Position> position; /** Creates a new
Builder */ private Builder() { super(SCHEMA$); } /** *
Creates a Builder by copying an existing Builder. * @param other The
existing Builder to copy. */ private
Builder(avro.examples.baseball.Player.Builder other) { super(other);
if (isValidValue(fields()[0], other.number)) { this.number =
data().deepCopy(fields()[0].schema(), other.number); fieldSetFlags()[0]
= true; } if (isValidValue(fields()[1], other.first_name)) {
this.first_name = data().deepCopy(fields()[1].schema(), other.first_name);
fieldSetFlags()[1] = true; } if (isValidValue(fields()[2],
other.last_name)) { this.last_name =
data().deepCopy(fields()[2].schema(), other.last_name);
fieldSetFlags()[2] = true; } if (isValidValue(fields()[3],
other.position)) { this.position = data().deepCopy(fields()[3].schema(),
other.position); fieldSetFlags()[3] = true; } } /** *
Creates a Builder by copying an existing Player instance * @param other The
existing instance to copy. */ private
Builder(avro.examples.baseball.Player other) { ] super(SCHEMA$)...>
{code}
{code}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Avro Java .................................. SUCCESS [2.489s]
[INFO] Apache Avro Guava Dependencies .................... SUCCESS [1.763s]
[INFO] Apache Avro ....................................... SUCCESS [1:15.980s]
[INFO] Apache Avro Compiler .............................. SUCCESS [8.408s]
[INFO] Apache Avro Maven Plugin .......................... SUCCESS [7.611s]
[INFO] Apache Avro IPC ................................... SUCCESS [1:12.651s]
[INFO] Trevni Java ....................................... SUCCESS [0.297s]
[INFO] Trevni Java Core .................................. SUCCESS [6.115s]
[INFO] Apache Avro Mapred API ............................ SUCCESS [1:55.159s]
[INFO] Trevni Java Avro .................................. SUCCESS [19.769s]
[INFO] Trevni Specification .............................. SUCCESS [0.513s]
[INFO] Apache Avro Tools ................................. FAILURE [34.268s]
[INFO] Apache Avro Protobuf Compatibility ................ SKIPPED
[INFO] Apache Avro Thrift Compatibility .................. SKIPPED
[INFO] Apache Avro Maven Archetypes ...................... SKIPPED
[INFO] Apache Avro Maven Service Archetype ............... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
{code}
> Add avroDoc on reflect
> ----------------------
>
> Key: AVRO-1658
> URL: https://issues.apache.org/jira/browse/AVRO-1658
> Project: Avro
> Issue Type: New Feature
> Components: java
> Affects Versions: 1.7.7
> Reporter: Zhaonan Sun
> Assignee: Zhaonan Sun
> Labels: reflection
> Attachments:
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch,
> 0001-AVRO-1658-Java-Add-reflection-annotation-AvroDoc.patch
>
>
> Looks like @AvroMeta can't add reserved fields, like @AvroMeta("doc", "some
> doc") will have exceptions.
> I would be greate if we have a @AvroDoc("some documentations") in
> org.apache.avro.reflect
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
