[
https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982264#comment-15982264
]
Hadoop QA commented on AVRO-1957:
---------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} buildtest {color} | {color:green} 0m
0s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 118 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
3s{color} | {color:red} The patch 16 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} buildtest {color} | {color:green} 6m
41s{color} | {color:green} the patch passed {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 7m 19s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Image:yetus/avro:793178a |
| JIRA Issue | AVRO-1957 |
| GITHUB PR | https://github.com/apache/avro/pull/154 |
| Optional Tests | buildtest javac |
| uname | Linux 50a6b138572d 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 GNU/Linux |
| Build tool | build |
| git revision | master / 793178a |
| Default Java | 1.7.0_111 |
| whitespace |
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/4/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/4/artifact/patchprocess/whitespace-tabs.txt
|
| modules | C: lang/java U: lang/java |
| Console output |
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/4/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
> Key: AVRO-1957
> URL: https://issues.apache.org/jira/browse/AVRO-1957
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.8.1
> Reporter: Sean Timm
> Assignee: Sean Timm
> Fix For: 1.8.2
>
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and
> time conversions do not implement getRecommendedSchema(). When trying to
> dynamically generate an Avro schema from a pojo that contains a DateTime
> object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
> return
> LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
