[
https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983785#comment-15983785
]
Suraj Acharya commented on AVRO-1957:
-------------------------------------
Sorry that was due to a configuration error. I have fixed it now.
{code}
JIRA Plugin: no credentials provided to write a comment.
+1 overall
| Vote | Subsystem | Runtime | Comment
============================================================================
| 0 | reexec | 0m 17s | Docker mode activated.
| +1 | @author | 0m 0s | The patch does not contain any @author
| | | | tags.
| +1 | buildtest | 0m 0s | master passed
| +1 | whitespace | 0m 0s | The patch has no whitespace issues.
| +1 | buildtest | 6m 34s | the patch passed
| | | 6m 55s |
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.13.1 Server=1.13.1 Image:yetus/avro:793178a |
| JIRA Issue | AVRO-1957 |
| GITHUB PR | https://github.com/apache/avro/pull/154 |
| Optional Tests | buildtest javac |
| uname | Linux 58ded22ec82c 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6
15:44:32 UTC 2016 x86_64 GNU/Linux |
| Build tool | build |
| git revision | master / 793178a |
| Default Java | 1.7.0_111 |
| modules | C: lang/java U: lang/java |
| Console output |
https://builds.apache.org/job/PreCommit-AVRO-Build-TEST/9/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
{code}
> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
> Key: AVRO-1957
> URL: https://issues.apache.org/jira/browse/AVRO-1957
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.8.1
> Reporter: Sean Timm
> Assignee: Sean Timm
> Fix For: 1.8.2
>
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and
> time conversions do not implement getRecommendedSchema(). When trying to
> dynamically generate an Avro schema from a pojo that contains a DateTime
> object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
> return
> LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
