[
https://issues.apache.org/jira/browse/AVRO-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983277#comment-15983277
]
Sean Timm commented on AVRO-1957:
---------------------------------
[~hadoopqa] reported whitespace issues. I fixed three lines in the unit tests
that had whitespace issues. I see no tabs or other whitespace issues in the
pull request.
> TimeConversions do not implement getRecommendedSchema()
> -------------------------------------------------------
>
> Key: AVRO-1957
> URL: https://issues.apache.org/jira/browse/AVRO-1957
> Project: Avro
> Issue Type: Bug
> Affects Versions: 1.8.1
> Reporter: Sean Timm
> Assignee: Sean Timm
> Fix For: 1.8.2
>
>
> org.apache.avro.data.TimeConversions.TimestampConversion and other date and
> time conversions do not implement getRecommendedSchema(). When trying to
> dynamically generate an Avro schema from a pojo that contains a DateTime
> object using ReflectData, I get an unsupported operation exception.
> I think the implementation should be as simple as
> {code}
> @Override
> public Schema getRecommendedSchema() {
> return
> LogicalTypes.timestampMillis().addToSchema(Schema.create(Schema.Type.LONG));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
