[
https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990340#comment-15990340
]
Thiruvalluvan M. G. commented on AVRO-1723:
-------------------------------------------
[~zolyfarkas] I reviewed your work. It looks great. A few formatting issues and
conventions. There was one bug related to the use of Dequeue's {{getLast()}}.
Instead of asking you to make further changes (you have done several rounds
already), I made a pull request into your git repo.
https://github.com/zolyfarkas/avro/pull/1 Please see if my modifications are
good enough. If you like the changes, please merge them to your branch and
rebase it to the current master of Apache repo. If you don't like my changes or
want to modify parts of them, please go ahead.
I'll wait for a couple of days for others to comment. If there are no comments
or objections from the community, I'll merge your pull request.
Thank you for taking this up. This is a very useful improvement to the Schema
parser.
One more thing. You mention that the order of definition of named schema
elements in the IDL file doesn't matter any more. I think, while it is true for
Record types, the other named types such as Enum, Fixed must be defined at the
first occurrence. This is not a problem because they don't recurse. Probably in
a future patch we can take this restriction out as well.
> Add support for forward declarations in avro IDL
> ------------------------------------------------
>
> Key: AVRO-1723
> URL: https://issues.apache.org/jira/browse/AVRO-1723
> Project: Avro
> Issue Type: Improvement
> Affects Versions: 1.8.0
> Reporter: Zoltan Farkas
> Assignee: Zoltan Farkas
> Attachments: AVRO-1723.patch
>
>
> Currently Recursive data structures like:
> record SampleNode {
> int count = 0;
> array<SamplePair> samples = [];
> }
> record SamplePair {
> string name;
> SampleNode node;
> }
> It is not possible to declare in IDL,
> however it is possible to declare in avsc (with fix from
> https://issues.apache.org/jira/browse/AVRO-1667 )
> It is actually not complicated to implement, here is some detail on a
> possible implementation:
> https://github.com/zolyfarkas/avro/commit/210c50105717149f3daa39b8d4160b8548b8e363
> This would close a capability gap with google protocol buffers...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
