Thiruvalluvan, anything else we need to do before merging this in? let me know
thank you —Z > On May 10, 2017, at 2:45 PM, Zoltan Farkas <[email protected]> > wrote: > > Anything else left to do? > > let me know > > thank you > > —Z > >> On Apr 30, 2017, at 11:16 PM, Thiruvalluvan M. G. (JIRA) <[email protected]> >> wrote: >> >> >> [ >> https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990573#comment-15990573 >> ] >> >> Thiruvalluvan M. G. commented on AVRO-1723: >> ------------------------------------------- >> >> [~zolyfarkas] Great. I just added a test for forward reference: >> https://github.com/zolyfarkas/avro/pull/2. Please merge it to your branch >> when you can. >> >> I'll pull your patch in two days. >> >>> Add support for forward declarations in avro IDL >>> ------------------------------------------------ >>> >>> Key: AVRO-1723 >>> URL: https://issues.apache.org/jira/browse/AVRO-1723 >>> Project: Avro >>> Issue Type: Improvement >>> Affects Versions: 1.8.0 >>> Reporter: Zoltan Farkas >>> Assignee: Zoltan Farkas >>> Attachments: AVRO-1723.patch >>> >>> >>> Currently Recursive data structures like: >>> record SampleNode { >>> int count = 0; >>> array<SamplePair> samples = []; >>> } >>> record SamplePair { >>> string name; >>> SampleNode node; >>> } >>> It is not possible to declare in IDL, >>> however it is possible to declare in avsc (with fix from >>> https://issues.apache.org/jira/browse/AVRO-1667 ) >>> It is actually not complicated to implement, here is some detail on a >>> possible implementation: >>> https://github.com/zolyfarkas/avro/commit/210c50105717149f3daa39b8d4160b8548b8e363 >>> This would close a capability gap with google protocol buffers... >> >> >> >> -- >> This message was sent by Atlassian JIRA >> (v6.3.15#6346) >
