Thiru, when you get a chance can you look at the last version of the PR? thank you
—Z > On May 14, 2017, at 7:50 PM, Zoltan Farkas (JIRA) <[email protected]> wrote: > > > [ > https://issues.apache.org/jira/browse/AVRO-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009886#comment-16009886 > ] > > Zoltan Farkas commented on AVRO-1723: > ------------------------------------- > > [~thiru_mg] I have updated the PR to redo the guava code and shaded it just > like the main java lib. > > build.sh test passes now, please review, and let me know if this looks good. > > thank you > >> Add support for forward declarations in avro IDL >> ------------------------------------------------ >> >> Key: AVRO-1723 >> URL: https://issues.apache.org/jira/browse/AVRO-1723 >> Project: Avro >> Issue Type: Improvement >> Affects Versions: 1.8.0 >> Reporter: Zoltan Farkas >> Assignee: Zoltan Farkas >> Attachments: AVRO-1723.patch >> >> >> Currently Recursive data structures like: >> record SampleNode { >> int count = 0; >> array<SamplePair> samples = []; >> } >> record SamplePair { >> string name; >> SampleNode node; >> } >> It is not possible to declare in IDL, >> however it is possible to declare in avsc (with fix from >> https://issues.apache.org/jira/browse/AVRO-1667 ) >> It is actually not complicated to implement, here is some detail on a >> possible implementation: >> https://github.com/zolyfarkas/avro/commit/210c50105717149f3daa39b8d4160b8548b8e363 >> This would close a capability gap with google protocol buffers... > > > > -- > This message was sent by Atlassian JIRA > (v6.3.15#6346)
