[ 
https://issues.apache.org/jira/browse/AVRO-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334501#comment-16334501
 ] 

Adam Bellemare commented on AVRO-1340:
--------------------------------------

[~cutting] "I think that's what you're assuming in the first spreadsheet."
Yes, that is correct.

With regards to row 11, 12 & 13, yes, I have made a mistake and bar should be 
in the enum (as per the current field default rules). An correct, "foo" is 
never in the enum.
"Violates Rules" should be caught at schema-parse time, not read time. I have 
updated the doc to clarify these issues.

 

I am okay with the compatibility change, where a reader that used to throw an 
exception on an unknown field would now simply use the default. Perhaps this 
should be up to the client to determine if they would prefer to throw the 
exception or if they would simply prefer to use the default.

 

 

 

> use default to allow old readers to specify default enum value when 
> encountering new enum symbols
> -------------------------------------------------------------------------------------------------
>
>                 Key: AVRO-1340
>                 URL: https://issues.apache.org/jira/browse/AVRO-1340
>             Project: Avro
>          Issue Type: Improvement
>          Components: spec
>         Environment: N/A
>            Reporter: Jim Donofrio
>            Priority: Minor
>
> The schema resolution page says:
> > if both are enums:
> > if the writer's symbol is not present in the reader's enum, then an
> error is signalled.
> This makes it difficult to use enum's because you can never add a enum value 
> and keep old reader's compatible. Why not use the default option to refer to 
> one of enum values so that when a old reader encounters a enum ordinal it 
> does not recognize, it can default to the optional schema provided one. If 
> the old schema does not provide a default then the older reader can continue 
> to fail as it does today.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to