Adam Bellemare commented on AVRO-1340:

[~cutting], [~felixgv] [~zolyfarkas]

I submitted a PR above. Sorry for the delay, it took me a bit longer than I 
thought it would. I did change the implementation a bit as I went - the enum 
default is now only used when a unmatching symbol is read by the reader. It 
doesn't affect anything when a field is just not found by the reader (that is 
still the Field default's responsibility). I didn't the interplay between the 
two and the code was getting somewhat gnarly, so I simplified it and went with 
what you now see in the PR.

> use default to allow old readers to specify default enum value when 
> encountering new enum symbols
> -------------------------------------------------------------------------------------------------
>                 Key: AVRO-1340
>                 URL: https://issues.apache.org/jira/browse/AVRO-1340
>             Project: Avro
>          Issue Type: Improvement
>          Components: spec
>         Environment: N/A
>            Reporter: Jim Donofrio
>            Priority: Minor
> The schema resolution page says:
> > if both are enums:
> > if the writer's symbol is not present in the reader's enum, then an
> error is signalled.
> This makes it difficult to use enum's because you can never add a enum value 
> and keep old reader's compatible. Why not use the default option to refer to 
> one of enum values so that when a old reader encounters a enum ordinal it 
> does not recognize, it can default to the optional schema provided one. If 
> the old schema does not provide a default then the older reader can continue 
> to fail as it does today.

This message was sent by Atlassian JIRA

Reply via email to