[
https://issues.apache.org/jira/browse/AVRO-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456957#comment-16456957
]
ASF GitHub Bot commented on AVRO-2112:
--------------------------------------
sidshetye commented on issue #307: AVRO-2112: Target .NET Standard/Core in C#
URL: https://github.com/apache/avro/pull/307#issuecomment-385073516
hey @blachniet - changes look fantastic. But when running `dotnet test`
we're seeing some issues related with
`<TargetFrameworks>net35;net40;netcoreapp2.0</TargetFrameworks>` inside
`Avro.test.csproj`. Basically `net35` doesn't exist on newer Windows systems
and `net35` and `net40` don't exist on *nix platforms.
I'm not sure if this is a limitation of current tools in .net and I don't
have any definitive best path. What do you think of having `netcoreapp2.0` as
the default or pass target framework over the `dotnet` CLI (if it's even
possible)?
Details:
New windows machines lacking .net35
```
PS D:\projects\github\avro\lang\csharp\src\apache\test> dotnet test
Build started, please wait...
C:\Program
Files\dotnet\sdk\2.1.104\Microsoft.Common.CurrentVersion.targets(1126,5): error
MSB3644: The reference assemblies for framework ".NETFramework,Version=v3.5"
were not found. To resolve this, install the SDK or Targeting Pack for this
framework version or retarget your application to a version of the framework
for which you have the SDK or Targeting Pack installed. Note that assemblies
will be resolved from the Global Assembly Cache (GAC) and will be used in place
of reference assemblies. Therefore your assembly may not be correctly targeted
for the framework you intend.
[D:\projects\github\avro\lang\csharp\src\apache\test\Avro.test.csproj]
```
Linux, running `dotnet test` we get
```
user@linux:/mnt/d/projects/github/avro/lang/csharp/src/apache/test$ dotnet
test
Build started, please wait...
/usr/share/dotnet/sdk/2.1.101/Microsoft.Common.CurrentVersion.targets(1126,5):
error MSB3644: The reference assemblies for framework
".NETFramework,Version=v4.0" were not found. To resolve this, install the SDK
or Targeting Pack for this framework version or retarget your application to a
version of the framework for which you have the SDK or Targeting Pack
installed. Note that assemblies will be resolved from the Global Assembly Cache
(GAC) and will be used in place of reference assemblies. Therefore your
assembly may not be correctly targeted for the framework you intend.
[/mnt/d/projects/github/avro/lang/csharp/src/apache/test/Avro.test.csproj]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies
> --------------------------------------------------------------------
>
> Key: AVRO-2112
> URL: https://issues.apache.org/jira/browse/AVRO-2112
> Project: Avro
> Issue Type: Improvement
> Components: csharp
> Environment: - Visual Studio For Mac
> - Visual Studio 2017
> - mono 5.4.1.7 MacOSX
> - dotnet 2.0 (MacOSX and Windows 10)
> Reporter: Miljenko Cvjetko
> Assignee: Miljenko Cvjetko
> Priority: Minor
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Suugestion is to add .NET Standard/Core support.
> In order to support modern/new .NET (both standard netfx and dotnet core) it
> is necessary to convert projects to support .NET Standard Libraries.
> - conversion to .NET Standard [DONE]
> - added dotnet core sample (Avro.perf) [DONE]
> - added netfx (standrd .NET) sample Avro.perf.netfx [DONE]
> - unit testing updated to use NUnit 3
> Url for the github forked repo with branch will be added.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
