[
https://issues.apache.org/jira/browse/AVRO-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457225#comment-16457225
]
ASF GitHub Bot commented on AVRO-2112:
--------------------------------------
blachniet commented on issue #307: AVRO-2112: Target .NET Standard/Core in C#
URL: https://github.com/apache/avro/pull/307#issuecomment-385120407
Hey @sidshetye, I got the same results on my machines (both Windows and
Linux) when working on this. The `dotnet` CLI attempts to build using all
frameworks listed in the `.csproj`. However, you can override this with the
`--framework` argument.
When using `dotnet test` on either Windows or Linux, you should provide the
`--framework netcoreapp2.0` argument (mentioned in the [README
here](https://github.com/apache/avro/pull/307/files#diff-65d636700bfdf9f78c00d3fd22734c61R20)).
For more details on this error message, see [this issue in the MSBuild
project](https://github.com/Microsoft/msbuild/issues/1333#issuecomment-382332184).
In short, it seems that there is no plans to add support for targeting earlier
versions of the .NET Framework (3.5, 4.0) from the `dotnet` CLI.
### Side Note
In this pull request I aimed for additive changes only. That's why I did not
deprecate support for .NET Framework 3.5. That being said, I'm happy to
deprecate support for earlier versions of the .NET Framework in this project if
the rest of the community is happy with that. I'm perfectly happy to target
.NET Standard 2.0 (.NET Framework 4.6.1+ according to [the chart
here](https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support)).
I'm not sure who makes that kind of decision on this project.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> c# (.net) port to .NET Standard 2.0 and nuget (package) dependencies
> --------------------------------------------------------------------
>
> Key: AVRO-2112
> URL: https://issues.apache.org/jira/browse/AVRO-2112
> Project: Avro
> Issue Type: Improvement
> Components: csharp
> Environment: - Visual Studio For Mac
> - Visual Studio 2017
> - mono 5.4.1.7 MacOSX
> - dotnet 2.0 (MacOSX and Windows 10)
> Reporter: Miljenko Cvjetko
> Assignee: Miljenko Cvjetko
> Priority: Minor
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Suugestion is to add .NET Standard/Core support.
> In order to support modern/new .NET (both standard netfx and dotnet core) it
> is necessary to convert projects to support .NET Standard Libraries.
> - conversion to .NET Standard [DONE]
> - added dotnet core sample (Avro.perf) [DONE]
> - added netfx (standrd .NET) sample Avro.perf.netfx [DONE]
> - unit testing updated to use NUnit 3
> Url for the github forked repo with branch will be added.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
