Hello! I wanted to make sure to thank you for doing all this python2/3 work! I've learned a lot by watching and reading the Python PRs coming through.
I did a rough pass through the types of changes and cleanup, and I'm pretty happy :D I'll try to get more thorough pass done, but (indeed) I probably won't have a lot of time between now and the new year. All my best, Ryan On Fri, Dec 20, 2019 at 12:36 AM Michael A. Smith <[email protected]> wrote: > > Hi, I've finished building out a unified python approach in lang/py. > It passes our full Yetus tests in cpython 2.7 and 3.5. I also tested > it and passed locally in 3.6, 3.7 and 3.8 as well as pypy 7.2.0 for > both 2.7 and 3.6. > > The pull request is here: https://github.com/apache/avro/pull/744 > > I know many people are on holiday or unavailable in the near future, > but I would really appreciate some eyes on this if you can find the > time. The tests give me some confidence, but the change was a > significant lift, as Python3 and Python2 handle bytes and unicode > strings in substantially different ways. > > This gives us a path forward to unifying our python support (I mean, > dropping lang/py3 and focusing on one API in one place) as well as > managing the sunset of python 2 support altogether. > > Thank you for your help with this project, either way! > > - Michael
