[ 
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723977
 ]

ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 20:05
            Start Date: 09/Feb/22 20:05
    Worklog Time Spent: 10m 
      Work Description: zcsizmadia commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034146030


   1.12.0 sounds ok'ish. Additionally I would call these out in the ReadME as 
potential breaking / obsolete changes. I am still concerned that these changes 
will cause issues downstream to some people who inherit from these avro 
classes. 
   
   I am still not sure what we gain with these and dont really see th benefit 
vs risk. However if something is broken in the future, it can be fixed later I 
guess. It just seems unncesseray risk to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723977)
    Time Spent: 5.5h  (was: 5h 20m)

>  Remove accessible field value from GenericFixed
> ------------------------------------------------
>
>                 Key: AVRO-3368
>                 URL: https://issues.apache.org/jira/browse/AVRO-3368
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.0
>            Reporter: Kyle Schoonover
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5.5h
>  Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
>     get { return _value; }
> }        
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to 
> _value



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to