[
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723861
]
ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Feb/22 18:04
Start Date: 09/Feb/22 18:04
Worklog Time Spent: 10m
Work Description: zcsizmadia edited a comment on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034045795
This particular issue in this ticket was "protected readonly byte[] value;".
Which might have been the intent. It is not publicly available, howveer the
field should be available via inheritance. WHat this code is changing is the
the inheritance convcept of the class.
If an inherited class was using the "value" field, that code has to be
changed, since it will be marked as obsolete. Now the user will be forced to
use the Value setter, which might not be the intent todo in the inherited
class.
Most likely this use case is too simple, and my point is that in some other
cases, this pattern will break other codes, which are based on this library.
Break does not mean it wont work, since it is just obsolete,, however the
downstream users must change their code, becuase now the fields are marked
obsolte,and will be retired.
This seems to be a valid change if the itent is well defined, and and IMO
this should be part of a major version release, not a minor one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 723861)
Time Spent: 4.5h (was: 4h 20m)
> Remove accessible field value from GenericFixed
> ------------------------------------------------
>
> Key: AVRO-3368
> URL: https://issues.apache.org/jira/browse/AVRO-3368
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.0
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
> get { return _value; }
> }
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to
> _value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
