[ 
https://issues.apache.org/jira/browse/AVRO-3368?focusedWorklogId=723856&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-723856
 ]

ASF GitHub Bot logged work on AVRO-3368:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Feb/22 17:56
            Start Date: 09/Feb/22 17:56
    Worklog Time Spent: 10m 
      Work Description: KyleSchoonover commented on pull request #1519:
URL: https://github.com/apache/avro/pull/1519#issuecomment-1034039037


   Fields should not be publicly exposed in the first place.  Same pattern is 
Java.  They use Getters and Setters.  We (C#) use properties.  Additionally, 
this change is backwards compatible.  You would have at least a year to update, 
where you would get warnings that something is being deprecated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 723856)
    Time Spent: 4h 10m  (was: 4h)

>  Remove accessible field value from GenericFixed
> ------------------------------------------------
>
>                 Key: AVRO-3368
>                 URL: https://issues.apache.org/jira/browse/AVRO-3368
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>    Affects Versions: 1.11.0
>            Reporter: Kyle Schoonover
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 10m
>  Remaining Estimate: 0h
>
> Update:
> {code:java}
> protected readonly byte[] value; {code}
> to:
> {code:java}
> [Obsolete("Will deprecate in future release use Value property")]
> protected byte[] value
> {
>     get { return _value; }
> }        
> /// <summary>
> /// Value of this fixed schema.
> /// </summary>
> private readonly byte[] _value; {code}
> Additional changes will need to be made to change everything from value to 
> _value



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to