[
https://issues.apache.org/jira/browse/AVRO-3384?focusedWorklogId=729391&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729391
]
ASF GitHub Bot logged work on AVRO-3384:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 02:38
Start Date: 18/Feb/22 02:38
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1043765928
1. The pending PRs still have if statement changes, which I have concern
about, since it complicates the review process
2. Expression bodied members are used for ne readablity gain. As I mentioned
earlier we should discuss basic guidelines about that
3. I dont think the variables were supposed to be renamed, which causes the
diffs being more complex.
4. ...
As I mentioned eearlier, createing the PRs should have been started after
the guidelines are set and we agree how we proceed. This would make sure that
we respect your time and the reviewers time as well. The concern is not that it
cannot be reviewed, but the volume of the review will be significant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729391)
Time Spent: 8h 50m (was: 8h 40m)
> Define C# Coding Style Guidelines
> ---------------------------------
>
> Key: AVRO-3384
> URL: https://issues.apache.org/jira/browse/AVRO-3384
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
> Document in a markdown file the styling guidelines to adhere to. Discussion
> of changes to happen in the Pull Request.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
