[
https://issues.apache.org/jira/browse/AVRO-3384?focusedWorklogId=729781&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729781
]
ASF GitHub Bot logged work on AVRO-3384:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 18:32
Start Date: 18/Feb/22 18:32
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1044976823
I do not disagree on the fact that most likely (and I empasize most likely)
are non-breaking changes adn the unit tests are passing asw ell. Which is
great. However my personal view s that, since this is a mature library, the
risk appetite for massive reworks are very low. That is the reason I my
suggestion were focusing on "easy" and trivial changes.
However I dont think it is a reasonable expectation from a reviewer, that
they should analyze the code and getting involved in it, simply because the
massive size of the code base (in theory most likely I agree with you).
I think you need @martin-g or @RyanSkraba input on this, I feel we approach
this from a totally different agle and of course I might be dead wrong ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729781)
Time Spent: 9h 10m (was: 9h)
> Define C# Coding Style Guidelines
> ---------------------------------
>
> Key: AVRO-3384
> URL: https://issues.apache.org/jira/browse/AVRO-3384
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> Document in a markdown file the styling guidelines to adhere to. Discussion
> of changes to happen in the Pull Request.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
