[
https://issues.apache.org/jira/browse/AVRO-3384?focusedWorklogId=729772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729772
]
ASF GitHub Bot logged work on AVRO-3384:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 18:19
Start Date: 18/Feb/22 18:19
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1534:
URL: https://github.com/apache/avro/pull/1534#issuecomment-1044959521
As for 1, 2 and 3 they are all defined in the editorconfig. Additionally, I
only changed private name, which should affect nothing on the public API. To
implement these styling guidelines I find it best to just get it over with.
Otherwise you take something that can be done in a matter of days and drag it
out for months. The local tests pass, as well as this code has been ported
over to my companies version of the library and I get the same results on over
6000 schemas. These are all non breaking changes, and do not change the
functionality of the library.
I find it best to treat these as if they were completely new files. Which
should make those who review them more involved and informed what the code base
does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 729772)
Time Spent: 9h (was: 8h 50m)
> Define C# Coding Style Guidelines
> ---------------------------------
>
> Key: AVRO-3384
> URL: https://issues.apache.org/jira/browse/AVRO-3384
> Project: Apache Avro
> Issue Type: Sub-task
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h
> Remaining Estimate: 0h
>
> Document in a markdown file the styling guidelines to adhere to. Discussion
> of changes to happen in the Pull Request.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
