[
https://issues.apache.org/jira/browse/AVRO-3421?focusedWorklogId=733335&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733335
]
ASF GitHub Bot logged work on AVRO-3421:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Feb/22 21:09
Start Date: 25/Feb/22 21:09
Worklog Time Spent: 10m
Work Description: martin-g commented on a change in pull request #1569:
URL: https://github.com/apache/avro/pull/1569#discussion_r815152865
##########
File path: lang/csharp/src/apache/test/Schema/ArraySchemaTests.cs
##########
@@ -0,0 +1,37 @@
+using NUnit.Framework;
Review comment:
You need to add the license header at the top of this new file. See
ArraySchema.cs for example
##########
File path: lang/csharp/src/apache/test/Schema/ArraySchemaTests.cs
##########
@@ -0,0 +1,37 @@
+using NUnit.Framework;
+
+namespace Avro.test
+{
+ [TestFixture]
+ public class ArraySchemaTests
+ {
+ [Test]
+ public void EqualsNullCheck()
+ {
+ string schemaString = "{\"type\": \"array\", \"items\": \"long\"}";
+ ArraySchema nullSchema = null;
+
+ Schema schema = Schema.Parse(schemaString);
+
+ if (schema is ArraySchema arraySchema)
+ {
+ Assert.False(arraySchema.Equals(nullSchema));
+ }
+ else
+ {
+ Assert.Fail("Schema was not an Array Schema");
Review comment:
`Array Schema must not be equal to null` ?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733335)
Remaining Estimate: 0h
Time Spent: 10m
> Add tests for ArraySchema
> -------------------------
>
> Key: AVRO-3421
> URL: https://issues.apache.org/jira/browse/AVRO-3421
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add additional code coverage to the ArraySchema class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
