[
https://issues.apache.org/jira/browse/AVRO-3421?focusedWorklogId=733429&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733429
]
ASF GitHub Bot logged work on AVRO-3421:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/22 00:24
Start Date: 26/Feb/22 00:24
Worklog Time Spent: 10m
Work Description: KyleSchoonover edited a comment on pull request #1569:
URL: https://github.com/apache/avro/pull/1569#issuecomment-1051381652
Just wanted to call this out to @martin-g and @zcsizmadia. Is there a
reason the ArraySchema class doesn't just use the following instead of the
private constructor and the static NewInstance method?
`internal ArraySchema(JToken jtok, PropertyMap props, SchemaNames names,
string encspace) : base(Type.Array, props)
{
}`
With the functionality of both put into this one constructor.
Also the addition of: `private ArraySchema(Schema items, PropertyMap props)
: base(Type.Array, props) {}` so that it can't be instantiated without using
the constructor.
I can put this in a separate PR, but just trying to understand if there was
some intention that I don't see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733429)
Time Spent: 1h (was: 50m)
> Add tests for ArraySchema
> -------------------------
>
> Key: AVRO-3421
> URL: https://issues.apache.org/jira/browse/AVRO-3421
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Add additional code coverage to the ArraySchema class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
