[
https://issues.apache.org/jira/browse/AVRO-3421?focusedWorklogId=733542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-733542
]
ASF GitHub Bot logged work on AVRO-3421:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/22 21:12
Start Date: 26/Feb/22 21:12
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on pull request #1569:
URL: https://github.com/apache/avro/pull/1569#issuecomment-1052621437
@martin-g I've been following Extreme Programming for so long that it is
rare that I implement code for potential changes (unless it's iterative
development where I am deploying pieces of functionality dark). I understand
that factory pattern when it comes to NamedSchema, However, UnnamedSchema,
while it follows a similar implementation there was nothing in the base class
enforcing the use of a factory pattern, which is why this was throwing me off.
I'm a bit indifferent about changing it, but NewInstance's accessor is internal
(this doesn't exist in Java to my knowledge), which means only the Avro.Main
library can create an instance. As far as I can tell moving this to an
internal constructor the only place that would need changes are in the
Schema.Parse method. So the only way for a user of this library is to call
Schema.Parse to create an ArraySchema.
On the other hand, We could make UnnamedSchema follow the factory pattern to
enforce it on those that inherit it. That would be a breaking change though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 733542)
Time Spent: 1h 50m (was: 1h 40m)
> Add tests for ArraySchema
> -------------------------
>
> Key: AVRO-3421
> URL: https://issues.apache.org/jira/browse/AVRO-3421
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Add additional code coverage to the ArraySchema class.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
