[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744715
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/22 15:00
Start Date: 20/Mar/22 15:00
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on pull request #1605:
URL: https://github.com/apache/avro/pull/1605#issuecomment-1073269194
System.Dom is an internal dependency of the main Avro library. With this
change you will force that dependency to the parent project which is using the
generated code. To make it more complicated, you do it implicitly. Implicitly I
mean, that it will magically work, because the Avro library will pull in the
System.Dom package, however the end user has no idea about it. The end user
shoudl use PackageReference explicitly to make sure that the Dom library is
referenced in tha main csproj file (which owns the generated cs file).
By making the Avro library's internal dependecny external, this change will
create a major future backward compatibility issue. The System.Dom package
cannot be removed any more from the AVro library (without potential
breaks).E.g. we decide that instead of the Dom compiler some other alternatives
are used to generate the code, and we remove System.Dom from the Avro
libaray's dependencies, all generated codes will fail compiling.
This very same issue happened with one of the code generators library in the
past. Unfortunately I dont remember if it was swagger, openapi or the thrift
compiler. It was a very similar issue, but not with Dom, but some other library.
What other alternatives are to exclude the generated source files? Is there
any csproj property setting where excluded files can be specified?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744715)
Time Spent: 1h 50m (was: 1h 40m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
