[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744797&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744797
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/22 23:25
Start Date: 20/Mar/22 23:25
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on a change in pull request #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r830690151
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
1. Unfortunately `1.12.0-rc.1`, `1.12.0-rc.2` and `1.12.0` will be shown
as `1.12.0.0`. Which seems to be incorrect behavior. Please change it to the
full version,
2, Namespaces are getting tricky, especially with the latest global usings.
It is preferred to use `::global` just to avoid any issue if someone is
implementing its own `GeneratedCodeAttribute`. E.g. Google protobuf is doing
the same.
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
1. Unfortunately `1.12.0-rc.1`, `1.12.0-rc.2` and `1.12.0` will be shown
as `1.12.0.0`. Which seems to be incorrect behavior. Please change it to the
full version,
2, Namespaces are getting tricky, especially with the latest global usings.
It is preferred to use `::global` just to avoid any issue if someone is
implementing its own `GeneratedCodeAttribute`. E.g. Google protobuf is doing
the same.
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
1. Unfortunately `1.12.0-rc.1`, `1.12.0-rc.2` and `1.12.0` will be shown
as `1.12.0.0`. Which seems to be incorrect behavior. Please change it to the
full version
2. Namespaces are getting tricky, especially with the latest global usings.
It is preferred to use `::global` just to avoid any issue if someone is
implementing its own `GeneratedCodeAttribute`. E.g. Google protobuf is doing
the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744797)
Time Spent: 3h 20m (was: 3h 10m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
