[
https://issues.apache.org/jira/browse/AVRO-3453?focusedWorklogId=744833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-744833
]
ASF GitHub Bot logged work on AVRO-3453:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/22 04:10
Start Date: 21/Mar/22 04:10
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on a change in pull request
#1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r830748262
##########
File path: lang/csharp/src/apache/main/CodeGen/CodeGenUtil.cs
##########
@@ -132,5 +144,21 @@ public string UnMangle(string name)
builder.Append(name[i]);
return builder.ToString();
}
+
+ private CodeAttributeDeclaration GetGeneratedCodeAttribute()
Review comment:
1. A little unsure on how to get the updated versioning, since this is
how the project has been configured as well as the version is the same one we
use in the ` <auto-generated>` header.
`System.Reflection.Assembly.GetExecutingAssembly().GetName().Version`
2. Added `global::` Which is just odd to me since this used to be a big
thing not to do with things under System. I know there are changes to support
how .Net 6 is doing things, which means a lot more global usings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 744833)
Time Spent: 3.5h (was: 3h 20m)
> C# Avrogen Add Generated Code Attribute
> ---------------------------------------
>
> Key: AVRO-3453
> URL: https://issues.apache.org/jira/browse/AVRO-3453
> Project: Apache Avro
> Issue Type: Improvement
> Components: csharp
> Affects Versions: 1.11.1
> Reporter: Kyle Schoonover
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Development environments that use Code Analysis or something similar attempt
> to exclude auto generated code. By adding this attribute to generated
> classes, code analysis will skip over evaluating the code.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
