[
https://issues.apache.org/jira/browse/AVRO-3503?focusedWorklogId=760460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760460
]
ASF GitHub Bot logged work on AVRO-3503:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 22:01
Start Date: 21/Apr/22 22:01
Worklog Time Spent: 10m
Work Description: KyleSchoonover commented on PR #1666:
URL: https://github.com/apache/avro/pull/1666#issuecomment-1105803486
I can break it out into separate PR's. I'm going to use this as a bucket to
check against the CI pipelines.
As for SequenceEqual, I find it better than the for loops and nested if
statements as long as it is comparing simple types. I'm reluctant to use it
for complex types.
Issue Time Tracking
-------------------
Worklog Id: (was: 760460)
Time Spent: 50m (was: 40m)
> C# Equals should not apply 'is' or 'as'
> ---------------------------------------
>
> Key: AVRO-3503
> URL: https://issues.apache.org/jira/browse/AVRO-3503
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> References:
> [Equals should not apply “is” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-is/]
> [Equals should not apply “as” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-as/]
>
> This will not allow equals methods to work correctly when dealing with
> inheritance.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
