[
https://issues.apache.org/jira/browse/AVRO-3503?focusedWorklogId=760468&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760468
]
ASF GitHub Bot logged work on AVRO-3503:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 22:16
Start Date: 21/Apr/22 22:16
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on PR #1666:
URL: https://github.com/apache/avro/pull/1666#issuecomment-1105814556
The other issue is changing the code behaviour of the Equals functions. It
is standard practice to either throwing a exception if the argument is null or
returning false. Some of the changes would return false instead of throwing the
exception (which is the current implementation in some of those codes). Which
might be ok, if we mark this PR as a major release PR, but in that case, the
scope is definetely as it is described in the ticket.
Issue Time Tracking
-------------------
Worklog Id: (was: 760468)
Time Spent: 1h 10m (was: 1h)
> C# Equals should not apply 'is' or 'as'
> ---------------------------------------
>
> Key: AVRO-3503
> URL: https://issues.apache.org/jira/browse/AVRO-3503
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> References:
> [Equals should not apply “is” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-is/]
> [Equals should not apply “as” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-as/]
>
> This will not allow equals methods to work correctly when dealing with
> inheritance.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
