[
https://issues.apache.org/jira/browse/AVRO-3503?focusedWorklogId=760462&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760462
]
ASF GitHub Bot logged work on AVRO-3503:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 22:07
Start Date: 21/Apr/22 22:07
Worklog Time Spent: 10m
Work Description: zcsizmadia commented on PR #1666:
URL: https://github.com/apache/avro/pull/1666#issuecomment-1105807947
The complexity of reviewing the SequenceEqual change is definetely higher
than the actual problem the ticket scopes for. E.g. SequenceEqual is using the
default comparer `EquityComparer<string>.Default`. Which is in your case is the
`Ordinal` comparison code. IMO that knowledge is not trivial and can be easily
missed.
The unit tests should provide the baseline for the changes you make, unless
the changes are trivial.
Issue Time Tracking
-------------------
Worklog Id: (was: 760462)
Time Spent: 1h (was: 50m)
> C# Equals should not apply 'is' or 'as'
> ---------------------------------------
>
> Key: AVRO-3503
> URL: https://issues.apache.org/jira/browse/AVRO-3503
> Project: Apache Avro
> Issue Type: Bug
> Components: csharp
> Reporter: Kyle Schoonover
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> References:
> [Equals should not apply “is” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-is/]
> [Equals should not apply “as” — CodeQL query help documentation
> (github.com)|https://codeql.github.com/codeql-query-help/csharp/cs-equals-uses-as/]
>
> This will not allow equals methods to work correctly when dealing with
> inheritance.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
