[
https://issues.apache.org/jira/browse/AVRO-3571?focusedWorklogId=788857&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788857
]
ASF GitHub Bot logged work on AVRO-3571:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/22 06:38
Start Date: 08/Jul/22 06:38
Worklog Time Spent: 10m
Work Description: KalleOlaviNiemitalo commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r916506878
##########
lang/py/avro/io.py:
##########
@@ -940,9 +931,7 @@ def skip_record(self, writers_schema:
avro.schema.RecordSchema, decoder: BinaryD
self.skip_data(field.type, decoder)
def _read_default_value(self, field_schema: avro.schema.Schema,
default_value: object) -> object:
- """
- Basically a JSON Decoder?
- """
+ """Basically a JSON Decoder?"""
Review Comment:
While looking at this, I found what appears to be a bug in
`_read_default_value`. Filed as [[AVRO-3572] Python encodes default value of
bytes field as UTF-8](https://issues.apache.org/jira/browse/AVRO-3572).
Issue Time Tracking
-------------------
Worklog Id: (was: 788857)
Time Spent: 1h 10m (was: 1h)
> Python code refactor and rearrangement
> --------------------------------------
>
> Key: AVRO-3571
> URL: https://issues.apache.org/jira/browse/AVRO-3571
> Project: Apache Avro
> Issue Type: Improvement
> Components: python
> Reporter: Diptonil Roy
> Priority: Minor
> Labels: beginner, easyfix, newbie, pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The changes made are:
> # Code altered according to PEP 8 conventions. Files changed are: io.py,
> constants.py, schema.py, codecs.py, datafile.py and compatibility.py.
> # General constants INT_MIN_VALUE, INT_MAX_VALUE, LONG_MIN_VALUE &
> LONG_MAX_VALUE shifted from schema.py to constants.py for clarity and better
> organization.
> (This is my first attempt to contribute to any open source project, not only
> this project. If I have made any errors or have misunderstood any step,
> please forgive me. I would be happy to adhere to any suggestions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
