[
https://issues.apache.org/jira/browse/AVRO-3571?focusedWorklogId=793353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793353
]
ASF GitHub Bot logged work on AVRO-3571:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/22 17:12
Start Date: 20/Jul/22 17:12
Worklog Time Spent: 10m
Work Description: kojiromike commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r925859992
##########
lang/py/avro/constants.py:
##########
@@ -57,3 +56,8 @@
)
VALID_TYPES = PRIMITIVE_TYPES + NAMED_TYPES + ("array", "map", "union",
"request", "error_union")
+
+INT_MIN_VALUE = -(1 << 31)
+INT_MAX_VALUE = (1 << 31) - 1
+LONG_MIN_VALUE = -(1 << 63)
+LONG_MAX_VALUE = (1 << 63) - 1
Review Comment:
I am fairly ambivalent about this change, because we don't appear to use
these particular constants in more than one module. They may as well be
"private". However, if it's useful externally for some reason, then I'm not
against it.
Issue Time Tracking
-------------------
Worklog Id: (was: 793353)
Time Spent: 1h 50m (was: 1h 40m)
> Python code refactor and rearrangement
> --------------------------------------
>
> Key: AVRO-3571
> URL: https://issues.apache.org/jira/browse/AVRO-3571
> Project: Apache Avro
> Issue Type: Improvement
> Components: python
> Reporter: Diptonil Roy
> Priority: Minor
> Labels: beginner, easyfix, newbie, pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The changes made are:
> # Code altered according to PEP 8 conventions. Files changed are: io.py,
> constants.py, schema.py, codecs.py, datafile.py and compatibility.py.
> # General constants INT_MIN_VALUE, INT_MAX_VALUE, LONG_MIN_VALUE &
> LONG_MAX_VALUE shifted from schema.py to constants.py for clarity and better
> organization.
> (This is my first attempt to contribute to any open source project, not only
> this project. If I have made any errors or have misunderstood any step,
> please forgive me. I would be happy to adhere to any suggestions)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
